smanikandan14 / ThinDownloadManager

To download files and to avoid using DOWNLOAD_WITHOUT_NOTIFICATION permission if you are using Android's DownloadManager in your apps.
Apache License 2.0
783 stars 185 forks source link

Fix a Issue: global variable mRequest lead to memory leak #88

Closed wangzhengyi closed 7 years ago

wangzhengyi commented 7 years ago

I use LeakCanary to test new code, there is no memory leak when request is set to local variable.

smanikandan14 commented 7 years ago

Rest of the changes looks good.

wangzhengyi commented 7 years ago

I already update change, @smanikandan14 please recheck again.

smanikandan14 commented 7 years ago

+1