Error: Unhandled HTTP code 1002 - why not return actual statuscode?

smanikandan14 / ThinDownloadManager

To download files and to avoid using DOWNLOAD_WITHOUT_NOTIFICATION permission if you are using Android's DownloadManager in your apps.

Apache License 2.0

783 stars 185 forks source link

Error: Unhandled HTTP code 1002 - why not return actual statuscode? #95

Open mrStudent123 opened 7 years ago

mrStudent123 commented 7 years ago

onDownloadFailed(DownloadRequest downloadRequest, int errorCode, String errorMessage)

error code = 1002 (Unhandled HTTP code) message = something like "response=not found, errorcode=404"

so why not return the 404 statuscode in the first place? Like this i can't display the correct error message without parsing the string, which is risky to break in future versions or with other errors.

smanikandan14 commented 7 years ago

I will work on it to provide the http status code in callbacks.

fjr619 commented 6 years ago

when it will have that htto status code in callbacks?