Feature/#546 add app name argument on new piral

[mgarciaar]

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

• [x] I have read the CONTRIBUTING document
• [x] My code follows the code style of this project
• [x] All new and existing tests passed

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

• [ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
• [x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)
• [x] I have updated the documentation accordingly
• [x] I have added tests to cover my changes

Description

I added a --appName property to the piral new command in order to define the package name without having to edit the package.json manually afterwards.

Remarks

I've added a simple test that checks the package.json "name" content. As there are other tests checking for the scaffolding structure I decided to maintain those checks.

[CLAassistant]

All committers have signed the CLA.

[github-actions[bot]]

File size impact

Merging feature/#546-add-appName-argument-on-new-piral into develop impact files as follow:

minimal-piral (no impact)

Files	new size
Unmodified (2)	250 kB (0 B / +0%)	:ghost:
Total (2)	250 kB (0 B / +0%)	:ghost:

sample-cross-fx (no impact)

Files	new size
Unmodified (3)	2.04 MB (0 B / +0%)	:ghost:
Total (3)	2.04 MB (0 B / +0%)	:ghost:

sample-piral (no impact)

Files	new size
Unmodified (3)	636 kB (0 B / +0%)	:ghost:
Total (3)	636 kB (0 B / +0%)	:ghost:

sample-piral-core (no impact)

Files	new size
Unmodified (3)	304 kB (0 B / +0%)	:ghost:
Total (3)	304 kB (0 B / +0%)	:ghost:

_{Generated by @jsenv/file-size-impact during check-bundle-size#3169819349 on 921cfc3}

[mgarciaar]

Yeah looks great - only thing I'd change for consistency is to use --app-name instead of --appName. Reason is that we also use, e.g., --force-overwrite and --npm-client instead of --forceOverwrite and --npmClient. This way, one always knows that camelCase (e.g., appName) is used within JS and dash-case (app-name) is for for CLI.

Ok, looks good to me. I'll change it now.