smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.71k stars 127 forks source link

Implemented #547: Add name argument to Pilet new. Changed appName arg… #553

Closed mgarciaar closed 2 years ago

mgarciaar commented 2 years ago

Add "name" argument to Pilet new. Changed appName argument of piral new to have the same syntax.

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Added argument "name" to pilet new command, used to assign the name to the package.json "project name". Also, I changed the piral new --app-name to have the same syntax: piral new --name.

github-actions[bot] commented 2 years ago

File size impact

Merging feature/#547-add-name-argument-on-new-pilet into develop impact files as follow:

minimal-piral (no impact)
Files new size
Unmodified (2) 250 kB (0 B / +0%) :ghost:
Total (2) 250 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.04 MB (0 B / +0%) :ghost:
Total (3) 2.04 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 638 kB (0 B / +0%) :ghost:
Total (3) 638 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 304 kB (0 B / +0%) :ghost:
Total (3) 304 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#3183524571 on 7925032

github-actions[bot] commented 2 years ago

File size impact

Merging feature/#547-add-name-argument-on-new-pilet into develop impact files as follow:

minimal-piral (no impact)
Files new size
Unmodified (2) 250 kB (0 B / +0%) :ghost:
Total (2) 250 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.04 MB (0 B / +0%) :ghost:
Total (3) 2.04 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 638 kB (0 B / +0%) :ghost:
Total (3) 638 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 304 kB (0 B / +0%) :ghost:
Total (3) 304 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#3183598640 on 73d2eee