smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.71k stars 127 forks source link

Docs: Change the Route of the Code Search to "/codes/search" to Align With the Piral CLI Output #604

Closed manuelroemer closed 1 year ago

manuelroemer commented 1 year ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

The Piral CLI, when running into an error code, tells us that we should go to https://docs.piral.io/code/search. The issue is that, at the moment, this page doesn't exist: grafik

I changed the routes/redirects in the documentation to match the output. I believe that the /code/search URL is the one we want to use (in contrast to the "old" /reference/codes/search)?

Locally, everything works fine now, see: grafik

grafik

Remarks

Does this go in the documentation branch? If not, change that please. 😄

manuelroemer commented 1 year ago

Oh right, I think I branched off develop. I can remake these changes, starting from documentation if that is an issue...

FlorianRappl commented 1 year ago

@manuelroemer

Oh right, I think I branched off develop. I can remake these changes, starting from documentation if that is an issue...

I think either put it back into develop (it will be merged into documentation on the next release, i.e., soon / today) or start with documentation as a branch.

manuelroemer commented 1 year ago

I think either put it back into develop [...]

I'll take that option then.