smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.68k stars 125 forks source link

Adding abort signal #622

Closed phildaniels closed 1 year ago

phildaniels commented 1 year ago

New Pull Request

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Adds abort signal as option to fetch function so it can be forwarded to native fetch

Remarks

I didn't add any tests because there were no existing tests for the files I modified

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 1 year ago

File size impact

Merging feature/621-add-abort-signal-to-fetch-plugin into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.6 kB (0 B / +0%) :ghost:
Total (2) 28.6 kB (0 B / +0%) :ghost:
minimal-piral (no impact)
Files new size
Unmodified (2) 251 kB (0 B / +0%) :ghost:
Total (2) 251 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) :ghost:
Total (3) 2.17 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 639 kB (0 B / +0%) :ghost:
Total (3) 639 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) :ghost:
Total (3) 305 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#5957121205 on d9c26c0