smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.71k stars 127 forks source link

Test improved pilet pack command #630

Closed FlorianRappl closed 1 year ago

FlorianRappl commented 1 year ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Fixes #629 and improves the pilet pack command by not requiring the temp dir / copy.

Remarks

I think overall this is much better than beforehand.

github-actions[bot] commented 1 year ago

File size impact

Merging hotfix/#629-dir-entries into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.7 kB (0 B / +0%) :ghost:
Total (2) 28.7 kB (0 B / +0%) :ghost:
minimal-piral (no impact)
Files new size
Unmodified (2) 252 kB (0 B / +0%) :ghost:
Total (2) 252 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) :ghost:
Total (3) 2.17 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 640 kB (0 B / +0%) :ghost:
Total (3) 640 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) :ghost:
Total (3) 305 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#6371155251 on 79097cd