smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.68k stars 125 forks source link

Define Importmap Version Behavior #631

Closed FlorianRappl closed 1 year ago

FlorianRappl commented 1 year ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Adds a special flag to the pilet.json, which can be used to define / override the default behavior when no version spec is given for a shared dependency.

Remarks

The default behavior is an exact match, but very often this is not what is wanted. In the future we might actually have the match-major behavior set (by default) in the pilet.json. Therefore, existing pilets will keep to work as-is, while newly scaffolded ones come with a new default, which can be seen and changed directly.

github-actions[bot] commented 1 year ago

File size impact

Merging feature/#625-importmap into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.7 kB (0 B / +0%) :ghost:
Total (2) 28.7 kB (0 B / +0%) :ghost:
minimal-piral (no impact)
Files new size
Unmodified (2) 252 kB (0 B / +0%) :ghost:
Total (2) 252 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.17 MB (0 B / +0%) :ghost:
Total (3) 2.17 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 640 kB (0 B / +0%) :ghost:
Total (3) 640 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 305 kB (0 B / +0%) :ghost:
Total (3) 305 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#6378534735 on 072951b