smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.68k stars 125 forks source link

fix: Exclude target from pack #642

Closed manuelroemer closed 10 months ago

manuelroemer commented 10 months ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Removes the target .tgz file from the list of files to be packed in the pilet pack command. This should solve an issue where packing of pilets fails when the target exists in the dist directory, e.g., as a leftover from a previous build.

Remarks

None.

github-actions[bot] commented 10 months ago

File size impact

Merging fix/pilet-pack-throws-when-target-exists-in-dist into develop impact files as follow:

empty-piral (no impact)
Files new size
Unmodified (2) 28.8 kB (0 B / +0%) :ghost:
Total (2) 28.8 kB (0 B / +0%) :ghost:
minimal-piral (no impact)
Files new size
Unmodified (2) 254 kB (0 B / +0%) :ghost:
Total (2) 254 kB (0 B / +0%) :ghost:
sample-cross-fx (no impact)
Files new size
Unmodified (3) 2.26 MB (0 B / +0%) :ghost:
Total (3) 2.26 MB (0 B / +0%) :ghost:
sample-piral (no impact)
Files new size
Unmodified (3) 645 kB (0 B / +0%) :ghost:
Total (3) 645 kB (0 B / +0%) :ghost:
sample-piral-core (no impact)
Files new size
Unmodified (3) 308 kB (0 B / +0%) :ghost:
Total (3) 308 kB (0 B / +0%) :ghost:

Generated by @jsenv/file-size-impact during check-bundle-size#6848910626 on 6d2cc4d