kevinkasper commented 10 months ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

What types of changes does your code introduce? Put an x in all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue, please reference the issue id)
[x] New feature (non-breaking change which adds functionality, make sure to open an associated issue first)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] I have updated the documentation accordingly
[x] I have added tests to cover my changes

This pull request enables the use of nested translations:

Before

{
    "header.title": "Hello world"
}

After

{
    "header": {
        "title": "Hello world"
    }
}

-

CLAassistant commented 10 months ago

All committers have signed the CLA.

github-actions[bot] commented 10 months ago

Merging feat/nested_translations into develop impact files as follow:

empty-piral (no impact)

Files	new size
Unmodified (2)	28.8 kB (0 B / +0%)	:ghost:
Total (2)	28.8 kB (0 B / +0%)	:ghost:

minimal-piral (no impact)

Files	new size
Unmodified (2)	276 kB (0 B / +0%)	:ghost:
Total (2)	276 kB (0 B / +0%)	:ghost:

sample-cross-fx (no impact)

Files	new size
Unmodified (3)	2.23 MB (0 B / +0%)	:ghost:
Total (3)	2.23 MB (0 B / +0%)	:ghost:

sample-piral (+0.24%)

Files	new size
src/samples/sample-piral/dist/release/index.0747fd.js	524 kB	:baby:
src/samples/sample-piral/dist/release/main.e49a32.css	170 kB	:baby:
~~src/samples/sample-piral/dist/release/main.59084b.css~~	deleted (-170 kB)
~~src/samples/sample-piral/dist/release/index.3dbdc4.js~~	deleted (-522 kB)
src/samples/sample-piral/dist/release/index.html	490 B (0 B / +0%)	:ghost:
Total (5)	695 kB (+1.68 kB / +0.24%)	:arrow_upper_right:

sample-piral-core (no impact)

Files	new size
Unmodified (3)	354 kB (0 B / +0%)	:ghost:
Total (3)	354 kB (0 B / +0%)	:ghost: