smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.68k stars 125 forks source link

Improve Toggle / Disable+Enable in Debug Tools #659

Closed FlorianRappl closed 9 months ago

FlorianRappl commented 9 months ago

New Feature Proposal

For more information, see the CONTRIBUTING guide.

Description

Right now when the disable (toggle in the Piral Inspector) option is used the pilet is essentially removed, however, the full lifecycle is not run. Therefore, stylesheets are already removed (for instance), but when a pilet is enabled again the stylesheet is never re-attached. Likewise, subsequent cleanups are not run.

Background

In a demo application when toggling the stylesheet is first removed (on first disable) but never attached again, leading to a broken design.

Discussion

(nothing)