smapiot / piral

🚀 Framework for next generation web apps using micro frontends. ⭐️ Star to support our work!
https://piral.io
MIT License
1.68k stars 125 forks source link

Bind `this` In Pilet API Event Functions #665

Closed manuelroemer closed 8 months ago

manuelroemer commented 8 months ago

New Pull Request

For more information, see the CONTRIBUTING guide.

Prerequisites

Please make sure you can check the following boxes:

Type(s) of Changes

Contribution Type

What types of changes does your code introduce? Put an x in all the boxes that apply:

Description

Fixes #664.

Remarks

None.

github-actions[bot] commented 8 months ago

File size impact

Merging fix/#644 into develop impact files as follow:

empty-piral (-0.06%)
Files new size
src/samples/empty-piral/dist/release/index.1de100.js 29.6 kB :baby:
src/samples/empty-piral/dist/release/index.18a434.js deleted (-29.6 kB)
src/samples/empty-piral/dist/release/index.html 315 B (0 B / +0%) :ghost:
Total (3) 29.9 kB (-18 B / -0.06%) :arrow_lower_right:
minimal-piral (-0.01%)
Files new size
src/samples/minimal-piral/dist/release/index.f1d72e.js 277 kB :baby:
src/samples/minimal-piral/dist/release/index.6523a1.js deleted (-277 kB)
src/samples/minimal-piral/dist/release/index.html 315 B (0 B / +0%) :ghost:
Total (3) 278 kB (-18 B / -0.01%) :arrow_lower_right:
sample-cross-fx (-0%)
Files new size
src/samples/sample-cross-fx/dist/release/index.9b0bd9.js 2.23 MB :baby:
src/samples/sample-cross-fx/dist/release/main.2ed1f6.css 1.67 kB :baby:
src/samples/sample-cross-fx/dist/release/main.85a2af.css deleted (-1.67 kB)
src/samples/sample-cross-fx/dist/release/index.7f378a.js deleted (-2.23 MB)
src/samples/sample-cross-fx/dist/release/index.html 454 B (0 B / +0%) :ghost:
Total (5) 2.23 MB (-14 B / -0%) :arrow_lower_right:
sample-piral (-0%)
Files new size
src/samples/sample-piral/dist/release/index.d64ddb.js 527 kB :baby:
src/samples/sample-piral/dist/release/main.7acfc3.css 170 kB :baby:
src/samples/sample-piral/dist/release/main.f1b976.css deleted (-170 kB)
src/samples/sample-piral/dist/release/index.43e53c.js deleted (-527 kB)
src/samples/sample-piral/dist/release/index.html 490 B (0 B / +0%) :ghost:
Total (5) 697 kB (-18 B / -0%) :arrow_lower_right:
sample-piral-core (-0.01%)
Files new size
src/samples/sample-piral-core/dist/release/index.92d54c.js 351 kB :baby:
src/samples/sample-piral-core/dist/release/main.4d6da5.css 3.6 kB :baby:
src/samples/sample-piral-core/dist/release/main.572b68.css deleted (-3.6 kB)
src/samples/sample-piral-core/dist/release/index.06275b.js deleted (-351 kB)
src/samples/sample-piral-core/dist/release/index.html 436 B (0 B / +0%) :ghost:
Total (5) 355 kB (-18 B / -0.01%) :arrow_lower_right:

Generated by @jsenv/file-size-impact during check-bundle-size#7558253187 on 029b6d7