search

smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
147 stars 130 forks source link

Feature: Implemented Date of creation of PDF #169

Closed Saransh-cpp closed 3 years ago

Saransh-cpp commented 3 years ago

Addressing #99

Changes

  1. Added Date feature to every PDF's card
  2. Now the Hive boxes, both starred and pdfs contain a list of lists at position 0. For ex - 
    [
['/this/is/some/path/file1.pdf', 'date1'], 
['/path/2/file2.pdf','date2']
]
  3. Integrated every existing feature to incorporate this change in the storage style.

Screenshot

Now only the picture feature is something that needs to be worked upon, please review and let me know if you want any changes in this PR.

(CWoC and GSSoC participant)

arteevraina commented 3 years ago

@Saransh-cpp Lint tests are failing can you please fix them ?

Saransh-cpp commented 3 years ago

@Saransh-cpp Lint tests are failing can you please fix them ?

Some of them are being worked upon by someone else, I will fix all the issues related to the PR I created.

arteevraina commented 3 years ago

@Saransh-cpp Lint tests are failing can you please fix them ?

Some of them are being worked upon by someone else, I will fix all the issues related to the PR I created.

Cool ! My bad I forgot that someone else was working on it.

Saransh-cpp commented 3 years ago

I fixed some small random lint issue too

Lint issues now (Not related to my PR)

  1. File names (being worked up in another PR)
  2. Image is deprecated and Image.provider should be used now but I can't figure out right now how to use it in our case.
  3. WatchBoxBuilder has been deprecated. (Will learn how to use the new one)
Saransh-cpp commented 3 years ago

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

smaranjitghose commented 3 years ago

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

Saransh-cpp commented 3 years ago

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

The dates were updated on their website, I confirmed in their discord and they said that the PRs merged till 12th March have been counted till now in the leader board and they will keep updating the leader board till 28th March which is the last date for the program. Can you please confirm this with them?

smaranjitghose commented 3 years ago

@smaranjitghose whenever you get time, please add the CrossWOC and difficulty labels.

CrossWoC evaluation is over. I have added it to all your PRs that were merged or raised before the deadline

The dates were updated on their website, I confirmed in their discord and they said that the PRs merged till 12th March have been counted till now in the leader board and they will keep updating the leader board till 28th March which is the last date for the program. Can you please confirm this with them?

Sure. I'll DM them

smaranjitghose commented 3 years ago

@Saransh-cpp Ya, just confirmed. Its' upto 28th. I'll update your scores accordingly then