search

smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
147 stars 130 forks source link

fix(Whole Project): renamed files. #174

Closed SapinderSingh closed 3 years ago

SapinderSingh commented 3 years ago

Renamed all files and fixed imports according to Dart Preferences.

fixes #160

SapinderSingh commented 3 years ago

@arteevraina Finally did it. Please check this now.

Saransh-cpp commented 3 years ago

There are a lot of small mistakes in this PR which will make the whole app stop working. For ex - Instead of 

import package:doclense/providers/theme_provider.dart

some files have the import 

import package:doclense/Providers/theme_provider.dart

Please ensure they are fixed.

SapinderSingh commented 3 years ago

There are a lot of small mistakes in this PR which will make the whole app stop working. For ex - Instead of

import package:doclense/providers/theme_provider.dart

some files have the import

import package:doclense/Providers/theme_provider.dart

Please ensure they are fixed.

Then what should be my next step? I have to delete this PR and add a new one ?

SapinderSingh commented 3 years ago

There are a lot of small mistakes in this PR which will make the whole app stop working. For ex - Instead of

import package:doclense/providers/theme_provider.dart

some files have the import

import package:doclense/Providers/theme_provider.dart

Please ensure they are fixed.

and can you tell me, why vs code and android studio are ignoring this?

Saransh-cpp commented 3 years ago

There are a lot of small mistakes in this PR which will make the whole app stop working. For ex - Instead of

import package:doclense/providers/theme_provider.dart

some files have the import

import package:doclense/Providers/theme_provider.dart

Please ensure they are fixed.

Then what should be my next step? I have to delete this PR and add a new one ?

No, you can fix these mistakes, commit the changes and push them and the new changes will automatically be reflected here. Please make sure to run the app first and push only when the app runs successfully. You can also have a look on all the issues by clicking details on the failed lint tests so that it becomes easier for you to locate and fix them.

SapinderSingh commented 3 years ago

@Saransh-cpp Please check

Saransh-cpp commented 3 years ago

@Saransh-cpp Please check

Great, all the imports and file names are fixed. I can't give the final judgement, you can request any of the mentors to do that! (you need to fix the conflicts though)