search

smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
151 stars 133 forks source link

Added image preview to PDF card in home screen #195

Closed Saransh-cpp closed 3 years ago

Saransh-cpp commented 3 years ago

Closes #193 Hopefully finally Closes #99

Changes

  1. The preview photo is added in the Hive box in a similar fashion as the date is added.
  2. All the storage style changes have been discussed in #169, and this PR uses that change of storage style to incorporate the storing of image too.

Screenshots

Please let me know if you want any changes in this PR, thanks!

(CWoC and GSSoC participant)

Saransh-cpp commented 3 years ago

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

anushbhatia commented 3 years ago

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

Saransh-cpp commented 3 years ago

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

This might be because you already have some PDFs in your app/Hive box which do not have a preview image as they were created before this code was written. Can you please once uninstall the app from your device then install it using the code from this branch and then let me know if this error still pops up?

anushbhatia commented 3 years ago

@anushbhatia was this error faced on starting up the app or after you created a PDF and opened the home screen?

startup on the home screen

This might be because you already have some PDFs in your app/Hive box which do not have a preview image as they were created before this code was written. Can you please once uninstall the app from your device then install it using the code from this branch and then let me know if this error still pops up?

🙌Sure let me check that.

anushbhatia commented 3 years ago

Screenshot_20210318_155537_com example doclense Overflow of icons

Saransh-cpp commented 3 years ago

@anushbhatia please check now

Saransh-cpp commented 3 years ago

Should I also fix the pixel overflow in imageview and filterview screens or is someone working on that?

anushbhatia commented 3 years ago

Should I also fix the pixel overflow in imageview and filterview screens or is someone working on that?

Nobody is working you can raise the pr.

Saransh-cpp commented 3 years ago

@anushbhatia could you please add the CrossWOC and the level labels on this PR