search

smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
147 stars 130 forks source link

Fixed renderflex overflow in the bottom nav bar #211

Closed Saransh-cpp closed 3 years ago

Saransh-cpp commented 3 years ago

Closes #178

Screenshots

  1. Pixel 2 <img src="https://user-images.githubusercontent.com/74055102/111690521-4b2f8280-8853-11eb-8796-8690ec0112a3.png" height="500px" />
  2. Redmi note 5 pro <img src="https://user-images.githubusercontent.com/74055102/111690590-669a8d80-8853-11eb-87be-8cc4f7d4eee5.jpg" height="500px" />

Please let me know if you want any changes in this PR, thanks!

(CWoC and GSSoC participant)

anushbhatia commented 3 years ago

Would it better to you safe area rather than this?

Saransh-cpp commented 3 years ago

Would it better to you safe are rather than this?

I'll check and let you know

anushbhatia commented 3 years ago

any update?

Saransh-cpp commented 3 years ago

any update?

Yes, putting the expanded widget in safe area gives the below error on console, the safe area was removed in #75 because of this error.

image

Saransh-cpp commented 3 years ago

@anushbhatia please add the respective CrossWOC labels