search

smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
147 stars 130 forks source link

Camera Modified.... Now After Take Image app not crash #227

Closed SamarpanCoder2002 closed 3 years ago

SamarpanCoder2002 commented 3 years ago

Now app will not crash when take image from camera....(Issue related: #210 )

Video Demo: https://drive.google.com/file/d/1RDKyyhrpEoUwKSvF-aPOlmST7cLVzfB6/view?usp=sharing

I am also a GSSOC'21 participant.....

Thank you @anushbhatia

SamarpanCoder2002 commented 3 years ago

hello @anushbhatia .... if it looks good..kindly merge it .... demo video also provided...

SamarpanCoder2002 commented 3 years ago

I think that problem lint check problems related to platform specific OS.... Problems arrive in ubuntu, windows, macos.....But that issues not problem the application.... But some of the isuues, I can't modified, as in one issue, it requested to use is not empty instead of length.... But at there, I have to write length to setup the logic..... So I think that will be not a problem to merge it.... because it works fine.. Thanks @anushbhatia

Saransh-cpp commented 3 years ago

I think that problem lint check problems related to platform specific OS.... Problems arrive in ubuntu, windows, macos.....But that issues not problem the application.... But some of the isuues, I can't modified, as in one issue, it requested to use is not empty instead of length.... But at there, I have to write length to setup the logic..... So I think that will be not a problem to merge it.... because it works fine.. Thanks @anushbhatia

The checks are failing because of some minor mistakes in the code (not necessarily errors but maybe a thing that can be replaced with something more efficient or a keyword that won't make a big difference right now but should be added), you can start by solving the smaller issues first and then figure out how to deal with the other issues. Some small issues -

  1. File name should be in small letters (something_like_this.dart).
  2. Placing the 'dart' imports before any other imports.
  3. Using const wherever a constant constructor is defined or called.
SamarpanCoder2002 commented 3 years ago

@anushbhatia Now all checks are passes and it looks fine....You can check again the demo video link.....I am also a GSSOC'21 participant ...... Please merge it ....Thank u

and @Saransh-cpp ...thanks a lot for help me

anushbhatia commented 3 years ago

Screenshot_20210326_013616_com example doclense My camera resolution is afted by this