smaranjitghose / DocLense

An open-source document scanner!
https://doclense.vercel.app/
Creative Commons Zero v1.0 Universal
152 stars 133 forks source link

adding splash screen #9

Closed Vrushti24 closed 3 years ago

Vrushti24 commented 3 years ago

Adding splash screen in app makes it look more attractive

Vrushti24 commented 3 years ago

I would love to work on it

smaranjitghose commented 3 years ago

Adding splash screen in app makes it look more attractive

Do let us know about the designs in this issue.

Vrushti24 commented 3 years ago

Yeah I will do that how time can u give me to design ? My classes are going on so

On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose notifications@github.com wrote:

Adding splash screen in app makes it look more attractive

Do let us know about the designs in this issue.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751624241, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA .

smaranjitghose commented 3 years ago

Yeah I will do that how time can u give me to design ? My classes are going on so On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose @.***> wrote: Adding splash screen in app makes it look more attractive Do let us know about the designs in this issue. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA .

Tomorrow evening? or within the next 1-2 days as per your schedule?

Vrushti24 commented 3 years ago

Yeah, I can do that. First I have to show u the design then after you say yes after I will implement it okayy

On Mon, Dec 28, 2020, 2:06 PM Smaranjit Ghose notifications@github.com wrote:

Yeah I will do that how time can u give me to design ? My classes are going on so … <#m-87110268003292487> On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose @.***> wrote: Adding splash screen in app makes it look more attractive Do let us know about the designs in this issue. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment) https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751624241>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA .

Tomorrow evening? or within the next 1-2 days as per your schedule?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751632709, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGEMMBPWBOTYRP4F4DSXA7QRANCNFSM4VK7MBCA .

smaranjitghose commented 3 years ago

Yeah, I can do that. First I have to show u the design then after you say yes after I will implement it okayy On Mon, Dec 28, 2020, 2:06 PM Smaranjit Ghose notifications@github.com wrote: Yeah I will do that how time can u give me to design ? My classes are going on so … <#m-87110268003292487> On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose @.***> wrote: Adding splash screen in app makes it look more attractive Do let us know about the designs in this issue. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment) <#9 (comment)>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA . Tomorrow evening? or within the next 1-2 days as per your schedule? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGEMMBPWBOTYRP4F4DSXA7QRANCNFSM4VK7MBCA .

Ya. Do you use AdobeXD? If you design it there, you can generate the Flutter code directly using a plugin. Also, feel free to shoot messages to @anushbhatia. He's our UI/UX ninja. I am more on the scripting side

Vrushti24 commented 3 years ago

No I don't know anything about adobeXD I can do on vscode but I will try thank u

On Mon, Dec 28, 2020, 2:13 PM Smaranjit Ghose notifications@github.com wrote:

Yeah, I can do that. First I have to show u the design then after you say yes after I will implement it okayy On Mon, Dec 28, 2020, 2:06 PM Smaranjit Ghose notifications@github.com wrote: … <#m-8309020117126637991> Yeah I will do that how time can u give me to design ? My classes are going on so … <#m-87110268003292487> On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose @.***> wrote: Adding splash screen in app makes it look more attractive Do let us know about the designs in this issue. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 https://github.com/smaranjitghose/DocLense/issues/9 (comment) <#9 (comment) https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751624241>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA . Tomorrow evening? or within the next 1-2 days as per your schedule? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment) https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751632709>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGEMMBPWBOTYRP4F4DSXA7QRANCNFSM4VK7MBCA .

Ya. Do you use AdobeXD? If you design it there, you can generate the Flutter code directly using a plugin. Also, feel free to shoot messages to @anushbhatia https://github.com/anushbhatia. He's our UI/UX ninja. I am more on the scripting side

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751634643, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGKJRJOUCNDHKXSCQTSXBAMPANCNFSM4VK7MBCA .

Vrushti24 commented 3 years ago

hey the label DWOC is not added please add that @smaranjitghose

Vrushti24 commented 3 years ago

@smaranjitghose I would make an animated splash screen in which logo and text would be animated in center with a suitable background is that OK??

Vrushti24 commented 3 years ago

I have made the screen shall I upload that? . I have made animated splash screen and yes please add DWOC tag in it

On Mon, Dec 28, 2020, 2:17 PM Vrushti Shah vrushtishah24@gmail.com wrote:

No I don't know anything about adobeXD I can do on vscode but I will try thank u

On Mon, Dec 28, 2020, 2:13 PM Smaranjit Ghose notifications@github.com wrote:

Yeah, I can do that. First I have to show u the design then after you say yes after I will implement it okayy On Mon, Dec 28, 2020, 2:06 PM Smaranjit Ghose notifications@github.com wrote: … <#m_-5680456157424802871m-8309020117126637991> Yeah I will do that how time can u give me to design ? My classes are going on so … <#m-87110268003292487_> On Mon, Dec 28, 2020, 1:37 PM Smaranjit Ghose @.***> wrote: Adding splash screen in app makes it look more attractive Do let us know about the designs in this issue. — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 https://github.com/smaranjitghose/DocLense/issues/9 (comment) <#9 (comment) https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751624241>>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA . Tomorrow evening? or within the next 1-2 days as per your schedule? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#9 (comment) https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751632709>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGEMMBPWBOTYRP4F4DSXA7QRANCNFSM4VK7MBCA .

Ya. Do you use AdobeXD? If you design it there, you can generate the Flutter code directly using a plugin. Also, feel free to shoot messages to @anushbhatia https://github.com/anushbhatia. He's our UI/UX ninja. I am more on the scripting side

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/smaranjitghose/DocLense/issues/9#issuecomment-751634643, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARFAUSGKJRJOUCNDHKXSCQTSXBAMPANCNFSM4VK7MBCA .

smaranjitghose commented 3 years ago

I have made the screen shall I upload that? . I have made animated splash screen and yes please add DWOC tag in it On Mon, Dec 28, 2020, 2:17 PM Vrushti Shah @.> wrote: No I don't know anything about adobeXD I can do on vscode but I will try thank u On Mon, Dec 28, 2020, 2:13 PM Smaranjit Ghose @.> wrote: > Yeah, I can do that. First I have to show u the design then after you say > yes after I will implement it okayy On Mon, Dec 28, 2020, 2:06 PM Smaranjit > Ghose @. wrote: > … <#m_-5680456157424802871m-8309020117126637991> > Yeah I will do that how time can u give me to design ? My classes are > going on so … <#m-87110268003292487_> On Mon, Dec 28, 2020, 1:37 PM > Smaranjit Ghose @.> wrote: Adding splash screen in app makes it > look more attractive Do let us know about the designs in this issue. — You > are receiving this because you were assigned. Reply to this email directly, > view it on GitHub <#9 > <#9> (comment) <#9 > (comment) > <#9 (comment)>>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ARFAUSCHD5S6H425MXJGCP3SXA4CVANCNFSM4VK7MBCA > . Tomorrow evening? or within the next 1-2 days as per your schedule? — You > are receiving this because you were assigned. Reply to this email directly, > view it on GitHub <#9 (comment) > <#9 (comment)>>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ARFAUSGEMMBPWBOTYRP4F4DSXA7QRANCNFSM4VK7MBCA > . > > Ya. Do you use AdobeXD? > If you design it there, you can generate the Flutter code directly using > a plugin. > Also, feel free to shoot messages to @anushbhatia > https://github.com/anushbhatia. He's our UI/UX ninja. I am more on the > scripting side > > — > You are receiving this because you were assigned. > Reply to this email directly, view it on GitHub > <#9 (comment)>, > or unsubscribe > https://github.com/notifications/unsubscribe-auth/ARFAUSGKJRJOUCNDHKXSCQTSXBAMPANCNFSM4VK7MBCA > . >

Ya do give a PR

Vrushti24 commented 3 years ago

@smaranjitghose can u guide me how to make a PR ?

smaranjitghose commented 3 years ago

@smaranjitghose can u guide me how to make a PR ?

Sure. I have laid out the guide to it here

Vrushti24 commented 3 years ago

PR #16 added check it out.