Improve Footer Design - Githubissues

smaranjitghose / awesome-portfolio-websites

A community maintained open source project aimed at making a personal portfolio for researchers, developers, and analysts simple, fast, and less cumbersome. We make sure you have a full-fledged website to showcase your work while you can spend time on your learning and innovative endeavors.

https://portfolio.smaranjitghose.com/

MIT License

2.35k stars 1.48k forks source link

Improve Footer Design #265

Closed smaranjitghose closed 3 years ago

shikharcodes commented 3 years ago

Hey! I would like to work on this issue as a part of Nwoc. Can you assign this to me please?

chehak123 commented 3 years ago

Can i work on it as a part of nwoc?

Pranav016 commented 3 years ago

I would like to work on this issue.

subhangi2731 commented 3 years ago

can you please assign this issue to me? @smaranjitghose

chehak123 commented 3 years ago

Thanks for assigning it to me. Can you please brief out about what all to be added in footer?

Vishal-raj-1 commented 3 years ago

Hello @chehak123, You have to improve footer. Some Issues I get in footer is :

I think it should be like :

fo2

One More Thing you can do is Improve Icons in Dark theme .

fo3

@smaranjitghose @anushbhatia I think You should assign this issue to multiple people.

Nishant2907 commented 3 years ago

Hello can i work on this issue?

smaranjitghose commented 3 years ago

Hello @chehak123, You have to improve footer. Some Issues I get in footer is :

I think it should be like :

One More Thing you can do is Improve Icons in Dark theme .

@smaranjitghose @anushbhatia I think You should assign this issue to multiple people.

Would you like to work on the responsiveness bug

Nishant2907 commented 3 years ago

Hi @smaranjitghose i did some changes in the footer design, kindly look at the screenshots i am attaching and give your reviews. on max width

on reducing the width f the screen

kindly have a look and give ur reviews.

Nishant2907 commented 3 years ago

Hi @smaranjitghose, I have updated all the changes you asked for. I am making a PR kindly review it.

Vishal-raj-1 commented 3 years ago

.> on max width

Logo should be in center.

Vishal-raj-1 commented 3 years ago

Okay I am going to work on this issue. Will send the PR shortly.

Nishant2907 commented 3 years ago

Hey buddy, i am still working on the PR. Just hold on for a sec...

Vishal-raj-1 commented 3 years ago

Hey buddy, i am still working on the PR. Just hold on for a sec...

Sure buddy, I have no problem you can continue !! and take your time, I will solve another issue!!

Don't Hurry, Do it nicely. All the best @Nishant2907 🔥

Nishant2907 commented 3 years ago

Actually i had completed the issue previous night, just forgot to commit it. Will commit it within minutes. You can have a look at the commits. Also do tell if you find any loose ends in the code :)

Vishal-raj-1 commented 3 years ago

@Nishant2907 I love to do reviewing peers code. But because of guideline of NWOC, I can't review. So let wait @smaranjitghose Sir will review and merge and I will do the rest( I have seen it need lot more to do).

Keep Coding and Learning!!

Nishant2907 commented 3 years ago

Yep Sure,

Vishal-raj-1 commented 3 years ago

@Nishant2907 Hey Brother You have done awesome work 👏🏻 . Now logo and quotes are perfectly fine. I think there is something that I can work upon the icon part.

smaranjitghose commented 3 years ago

@Nishant2907 Hey Brother You have done awesome work 👏🏻 . Now logo and quotes are perfectly fine. I think there is something that I can work upon the icon part.

Sure. Go ahead