Bug Fix: PDF files can only be merged, other format options should not show in Output dropdown

smaranjitghose / doc2pen

An open source project aimed at making your student life easier!

https://doc2pen.smaranjitghose.com

Creative Commons Zero v1.0 Universal

381 stars 403 forks source link

Bug Fix: PDF files can only be merged, other format options should not show in Output dropdown #1038

Closed N-Shar-ma closed 3 years ago

N-Shar-ma commented 3 years ago

Problem:

Currently, when PDF files were selected, other image formats still showed up as conversion options. Chosing them would make nothing happen, so no error, but giving false options is bad UX

Solution:

When a PDF file is selected, user only is only shown the PDF option to merge them

Changes Made:

I've added a condition which sets output options to only PDF when a PDF file is dropped by the user