search

smaranjitghose / doc2pen

An open source project aimed at making your student life easier!
https://doc2pen.smaranjitghose.com
Creative Commons Zero v1.0 Universal
380 stars 404 forks source link

Menubar material #1070

Closed goyal-Dushi closed 3 years ago

goyal-Dushi commented 3 years ago

Addressing issue #1059. Designed the Editor UI using material and CSS

https://user-images.githubusercontent.com/40212568/124360378-118a5800-dc47-11eb-94a1-6b091593d7bc.mp4

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smaranjitghose/doc2pen/4PJ8WN3zTjHyrD5K9yeQYcTsMykw
✅ Preview: https://doc2pen-git-fork-goyal-dushi-menubar-material-smaranjitghose.vercel.app

goyal-Dushi commented 3 years ago

Hey @AbhipsaGuru1012, I have added your recommended changes.

goyal-Dushi commented 3 years ago

Double-clicking it goes away. So try resolving that cause if the user sets something and clicks it again it shouldn't go away.

Actually, I have made it so that the user could toggle through it. The user is supposed to click the option once in order to get the option to set values. If you want the option to remain after a single click then no problem, I can add so.

smaranjitghose commented 3 years ago

This_should

This should not overlap.

When I assigned the issue, I expected a redesign of the complete menubar and not replacement of certain text with material icons

goyal-Dushi commented 3 years ago

Hey, @smaranjitghose, I see you have closed the pull request, I can still customize the layout if you want and the overlap issue if you are accepting the pull request.