smaranjitghose / doc2pen

An open source project aimed at making your student life easier!

https://doc2pen.smaranjitghose.com

Creative Commons Zero v1.0 Universal

380 stars 404 forks source link

Making favicon more user friendly. #1078

Closed NS007-dev closed 3 years ago

NS007-dev commented 3 years ago

1077

@smaranjitghose I downloaded a favicon from flaticon, and changed the current one. I couldn't get to successfully clone locally, so I uploaded the files.

Please review.

vercel[bot] commented 3 years ago

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/smaranjitghose/doc2pen/6smZF1hmqKyqcrhat2WRhb3iAQrr
✅ Preview: https://doc2pen-git-fork-codingspecies-master-smaranjitghose.vercel.app

NS007-dev commented 3 years ago

@anushbhatia do you mean update the import code, to get the icon on the page? If so, I didn't change anything apart the image itself, so the filename is still the same, so the import code would be ok too. Thank you.

smaranjitghose commented 3 years ago

Check the meta component code please

smaranjitghose commented 3 years ago

Also, before giving the PR, please test the changes and attach a snapshot or clip of the same in the PR description.

NS007-dev commented 3 years ago

To make PR more efficient and cleaner, I am going to close the PR, and make a new one. Thank you