smaranjitghose / doc2pen

An open source project aimed at making your student life easier!
https://doc2pen.smaranjitghose.com
Creative Commons Zero v1.0 Universal
381 stars 404 forks source link

Remove inherited undesired stylings by using css modules #466

Closed ashuvssut closed 3 years ago

ashuvssut commented 3 years ago

Please have a look on this issue.

I have observed the same in thing in doc2pen codebase.

there are css files that need to be converted to module.css. currently some css styles are globally defined and therefore can affect other stylings. we must use css modules to prevent that.

please assign me this issue

anushbhatia commented 3 years ago

And clean up the unnecessary files too.

smaranjitghose commented 3 years ago

@ashuvssut any updates brother?

ashuvssut commented 3 years ago

giving PR in 5mins. I have completed it. just a merge conflict was remaining to solve😅

smaranjitghose commented 3 years ago

@ashuvssut @sanjay270899 @Abhijay007 .

Since Awesome Developer Portfolio is a part of the same open-source programs as Doc2Pen and we are planning to shift it to React (Eventually to Next) you are welcome to work on the transition issue for it and on parallel (not always but things like SEO, pre-loader, dark mode, etc) PRs for both projects if you wish

ashuvssut commented 3 years ago

sir, if you are talking about https://github.com/smaranjitghose/awesome-portfolio-websites, then I am very excited for it! Looking forward for those new issues.😁😁

ashuvssut commented 3 years ago

Sir, when is the new branch for react version getting pushed?

smaranjitghose commented 3 years ago

Sir, when is the new branch for react version getting pushed?

Well, the transition would be: