search

smaranjitghose / girlscript_app

A boilerplate for any technical community to pick up and use for their own without any hastle This app is a center to various events ranging from portraying the member’s achievements to announcing the upcoming opportunities. Additionally, this app developed by the community, and for the community, will add elegance. Plus, being as an open source project, this will be a golden opportunity for beginners to learn and contribute to it just like a cherry on the cake.
Creative Commons Zero v1.0 Universal
74 stars 107 forks source link

LinkedIn Authentication #278

Open himanshusharma89 opened 4 years ago

SirusCodes commented 4 years ago

I can do this by this package

himanshusharma89 commented 4 years ago

Okay, @SirusCodes go ahead. Assigning it to you.

SirusCodes commented 4 years ago

Yup Thanks👍

SirusCodes commented 4 years ago

@himanshusharma89 can you give me client id and client secret? You can send me a mail or message me any social media

himanshusharma89 commented 4 years ago

@SirusCodes you can create an example app yourself and try it, I'll change it after merging it

SirusCodes commented 4 years ago

Can you give me your android debug key or will you add mine to the project? I also need to use custom token as firebase doesn't support LinkedIn login natively Also please do the required in firebase as in the link above

himanshusharma89 commented 4 years ago

@SirusCodes share me your gmail, I'll add you to the project in the console.

SirusCodes commented 4 years ago

darshandrander@gmail.com

himanshusharma89 commented 4 years ago

@SirusCodes I have added you to the console, you can work on it now.

SirusCodes commented 4 years ago

I got the notification I would start working on it soon...

SirusCodes commented 4 years ago

Hey @himanshusharma89 I made changes in the application, but linkedin have a review process to allow sign in with linkedin. I don't think that my request would be accepted. So should I make a PR now or something else?

himanshusharma89 commented 4 years ago

@SirusCodes Create a PR from a different branch, I'll label it to be eligible for Hacktoberfest

SirusCodes commented 4 years ago

@himanshusharma89 why #285 is not counted as eligible PR for hacktoberfest?

himanshusharma89 commented 4 years ago

@SirusCodes Hacktoberfst added new rules against spamming, I'll add a label and it'll be counted. Check this: https://hacktoberfest.digitalocean.com/hacktoberfest-update

himanshusharma89 commented 4 years ago

@SirusCodes Check it now

SirusCodes commented 4 years ago

@himanshusharma89 Not yet...maybe it will take some time I guess...thanks😃

umang-sinha commented 2 years ago

Is this still active? I would like to work on this

himanshusharma89 commented 2 years ago

Sure @umang-sinha, assigning it to you.

himanshusharma89 commented 2 years ago

I am sure @SirusCodes has eyes on some other projects 😆

SirusCodes commented 2 years ago

@himanshusharma89 The issue should be closed by now as the code was complete, @umang-sinha maybe can fix deprecated APIs if any😅

@umang-sinha I would suggest you to continue with this PR.