search

smaranjitghose / girlscript_app

A boilerplate for any technical community to pick up and use for their own without any hastle This app is a center to various events ranging from portraying the member’s achievements to announcing the upcoming opportunities. Additionally, this app developed by the community, and for the community, will add elegance. Plus, being as an open source project, this will be a golden opportunity for beginners to learn and contribute to it just like a cherry on the cake.
Creative Commons Zero v1.0 Universal
74 stars 106 forks source link

Fixed the null on name bug in Google OAuth2 #286

Closed rish07 closed 3 years ago

rish07 commented 3 years ago
  1. The bug was because the user data wasn't being fetched anywhere after logging in from the Firestore but was used in the widget tree, so I have fixed this problem by fetching it on Dashboard.
  2. My github auth code was commented in the latest commit in the master branch, is there any bug in it?

Fixes #275

himanshusharma89 commented 3 years ago

@rish07 Good and no issues in GitHub Auth, I added the ClIent data in the secret file and added it in gitignore, which is causing issue to the new contributors and with the GitHub Action. as the import is invalid now. If you have a better approach to handle the secrets, I am all ears.

rish07 commented 3 years ago

@rish07 Good and no issues in GitHub Auth, I added the ClIent data in the secret file and added it in gitignore, which is causing issue to the new contributors and with the GitHub Action. as the import is invalid now. If you have a better approach to handle the secrets, I am all ears.

@himanshusharma89 sure, I'll reply if I can get a solution.