Updated Makefile with option BUILD_MINIMAL

[kcleal]

Hi @smarco, I was having trouble syncing my old branch, so I started a new one. This updates the Makefile and adds the BUILD_MINIMAL option. This replaces the BUILD_CPP option in the previous pull request as I think it better describes the purpose of the option. If BUILD_MINIMAL is set, only the core C lib should be built without CPP bindings and extras. Perhaps this could instead be named BUILD_CLIB_ONLY?

I also added the -fPIC flag which is currently needed for the python pywfa build. Thanks!

[smarco]

Ok, not a problem at all. Thanks for the effort and work.

Again, I am interested in offering a Python interface/bindings into the WFA2lib (under bindings/python). I didn't want to re-implement the py bindings, provided that you already did all that nice work. However, I respect if you want to keep the independence of your project. Also, I don't want to come across as invasive or imposing.

In any case, I would be happy to collaborate and implement this extension of the WFA2lib to python. Give it a thought and let me know.

[kcleal]

Thanks for accepting the pull request.

I would be very happy to try and merge the python bindings into your project under bindings/python. So far my python bindings are far from complete, only some of the main configurations of WFA2-lib are available for example.

How would you like to try and structure the bindings/python directory? I guess it could be similar to edlib https://github.com/Martinsos/edlib/tree/master/bindings/python where all files are within one folder, or it could be more like a contained python package similar to how pywfa is organised at the moment?

Kez

On 20 Jul 2022, at 20:52, Santiago Marco-Sola @.**@.>> wrote:

External email to Cardiff University - Take care when replying/opening attachments or links. Nid ebost mewnol o Brifysgol Caerdydd yw hwn - Cymerwch ofal wrth ateb/agor atodiadau neu ddolenni.

Ok, not a problem at all. Thanks for the effort and work.

Again, I am interested in offering a Python interface/bindings into the WFA2lib (under bindings/python). I didn't want to re-implement the py bindings, provided that you already did all that nice work. However, I respect if you want to keep the independence of your project. Also, I don't want to come across as invasive or imposing.

In any case, I would be happy to collaborate and implement this extension of the WFA2lib to python. Give it a thought and let me know.

— Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fsmarco%2FWFA2-lib%2Fpull%2F25%23issuecomment-1190691659&data=05%7C01%7Cclealk%40cardiff.ac.uk%7Cddc13bf371774eb658e908da6a895c52%7Cbdb74b3095684856bdbf06759778fcbc%7C1%7C0%7C637939435430535785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=Beg4bLrz7D5oBzsYlNSwbjboWusv45TN7CRxhyS8Cpo%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAKIBQHIB3QKK7KFM2UNF76TVVBKHJANCNFSM53OJKO2Q&data=05%7C01%7Cclealk%40cardiff.ac.uk%7Cddc13bf371774eb658e908da6a895c52%7Cbdb74b3095684856bdbf06759778fcbc%7C1%7C0%7C637939435430535785%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=EghHimBb9ENbFL0g5D%2FaiVGyagEnFlhlWz1u%2Ffw7Vuc%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

[smarco]

I would be very happy to try and merge the python bindings into your project under bindings/python. So far my python bindings are far from complete, only some of the main configurations of WFA2-lib are available for example.

Glad to hear that! I believe we can work together and offer these bindings out-of-the-box under bindings/python. Let us work on the bindings branch until we feel it can be merged into master.

How would you like to try and structure the bindings/python directory? I guess it could be similar to edlib https://github.com/Martinsos/edlib/tree/master/bindings/python where all files are within one folder,

That sounds like a good way to start with it. In any case, later on, we can discuss how to publish it in PyPI. It is my understanding that many users will find this useful. I am very open to any suggestions you can have on this. And, of course, full credit/authorship goes to you.