search

smarco / WFA2-lib

WFA-lib: Wavefront alignment algorithm library v2
Other
162 stars 36 forks source link

Allow zero gap open cost in affine2p #74

Closed ctsa closed 1 year ago

ctsa commented 1 year ago

There is a discrepancy between the error message and check when a gap open cost of zero is used in the dual-gap affine mode. The method appears to work with zero gap opening cost so I changed the check to match the error message here.

It also looks like this issue has come up and been addressed before (https://github.com/smarco/WFA2-lib/issues/52), but I don't see the change on the main branch:

smarco commented 1 year ago

I'm sorry for not getting back to you sooner.

I believe it is solved in the development branch (now merged on the main branch). Can you check that it is solved now?

ctsa commented 1 year ago

Confirmed that this is solved on main now, thank you.