search

smarco / WFA2-lib

WFA-lib: Wavefront alignment algorithm library v2
Other
162 stars 36 forks source link

Remove some unused headers #90

Closed 8051Enthusiast closed 7 months ago

8051Enthusiast commented 7 months ago

I was trying to compile this under windows using mingw, and some headers are not available there. However, it seems like those headers are not used anywhere in the library anyway (at least it compiles fine on windows after i remove these). At least for pwd.h and err.h I'm fairly certain that they're not used anywhere since it would be weird to use them in this library, for sys/mman.h it would certainly be plausible they'd be used here, but I could not find any mmap/madvice/mlock calls.

smarco commented 7 months ago

utils/commons.h is a programming malpractice I should have removed a long time ago. Thanks for the PR.