Closed larsoner closed 3 years ago
Merging #41 into master will decrease coverage by
0.18%
. The diff coverage is66.66%
.
@@ Coverage Diff @@
## master #41 +/- ##
==========================================
- Coverage 88.63% 88.45% -0.19%
==========================================
Files 31 31
Lines 1065 1074 +9
==========================================
+ Hits 944 950 +6
- Misses 121 124 +3
Impacted Files | Coverage Δ | |
---|---|---|
pytest_harvest/plugin.py | 62.12% <50.00%> (-0.19%) |
:arrow_down: |
pytest_harvest/results_session.py | 82.32% <60.00%> (-0.58%) |
:arrow_down: |
...test_harvest/tests_raw/test_get_session_results.py | 96.21% <100.00%> (+0.05%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 00a713c...0a90b0a. Read the comment docs.
Thanks @larsoner ! I'll have a look tomorrow
Thanks @larsoner ! Looks very good to me, I made a few comments that are mostly nitpicks really, just for the sake of making maintenance a bit easier on the long run.
All tests pass ok in Travis so I'll be able to merge when you'll have made the updates. (the only failure that I see is in the "raw" tests, and is intended - it is then collected by the META test runner and expected to fail)
@smarie comments addressed
There is a wall of red here :)
https://travis-ci.org/github/smarie/python-pytest-harvest/builds/727704884
Let me know if you want my help fixing it
Hi @larsoner I merged manually and fixed the meta-tester, everything is fine now and 1.9.3 is available.
There were 2 issues
Let me know if the released version is ok for you. And thanks again !!
@smarie yes, just pip install pytest-harvest
works now!
great, thanks for the feedback and PR @larsoner !
Fixes #42
On
master
using--doctest-modules
with fixtures leads to:and also
master
but passes here, along with dummydoctestable
functionDoctestItem
item_obj is None
casepytest_harvest/_version.py
to.gitignore
(I assume this is useful?)FWIW locally not all tests pass actually, but the same set that fail on this PR also fail on
master
.