search

smarie / python-pytest-steps

A tiny package to ease the creation of test steps with shared intermediate results/state.
https://smarie.github.io/python-pytest-steps/
BSD 3-Clause "New" or "Revised" License
56 stars 5 forks source link

Use of deprecated getfuncargvalue #10

Closed denisdubovitskiy closed 5 years ago

denisdubovitskiy commented 5 years ago

Here is the warning: steps_parametrizer.py:94: RemovedInPytest4Warning: getfuncargvalue is deprecated, use getfixturevalue

Is it planned to be fixed? Thanks

smarie commented 5 years ago

Nice catch, thanks ! Yes, we'll have to take care of this indeed. Probably not much of a problem if getfixturevalue provides the same functionality and exists in legacy pytest versions. Otherwise we'll have to test for existence and choose whichever is available.

If you feel like you can have a go do not hesitate to propose a PR. Otherwise I'll have a look in the upcoming days

smarie commented 5 years ago

I did it, will push it now

denisdubovitskiy commented 5 years ago

Thank you! I was on the verge of making a PR, but unfortunately I didn't have time for it

smarie commented 5 years ago

ah sorry I should have waited slightly more.. this should now be fixed (in 1.0.1 that is being currently built by travis)