search

smarie / python-pytest-steps

A tiny package to ease the creation of test steps with shared intermediate results/state.
https://smarie.github.io/python-pytest-steps/
BSD 3-Clause "New" or "Revised" License
56 stars 5 forks source link

add step_bag fixture #46

Closed j-carson closed 2 years ago

j-carson commented 3 years ago

Creates a step_bag that makes a new pytest_harvest results_bag per step

smarie commented 3 years ago

Thanks @j-carson ! very nice PR. I made a few minor comments

Unfortunately I did not yet migrate this project to my new template with github actions :( So I'll have to update it first

j-carson commented 3 years ago

I will update the PR once I understand what you meant on that one doc comment. I obviously noticed there were build issues - I put what I did to make the repo build in a separate PR so you could see what I did to test this PR while keeping it separate from the code that was more likely to be actually merged.

-- Janet Carson @.***

On Mon, Sep 20, 2021, at 4:32 AM, Sylvain Marié wrote:

Thanks @j-carson https://github.com/j-carson ! very nice PR. I made a few minor comments

Unfortunately I did not yet migrate this project to my new template with github actions :( So I'll have to update it first

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/smarie/python-pytest-steps/pull/46#issuecomment-922846428, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKSBNGDAZGCVAUO7JVQE2PDUC4LVNANCNFSM5EJSF22Q. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

smarie commented 3 years ago

@j-carson I updated the main branch (warning it was renamed too)

You may wish to either try to merge it into this PR, or to create a new PR from it. Once you push your PR, the github actions build will run.

Let me know if you prefer that I do all of this.

j-carson commented 3 years ago

As I was reworking the docs I realized that to be logically complete, in addtion to providing a fixture that overrides the default results_bag for generator-mode steps, I should provide the complementary cross-steps bag for explicit-mode steps.

smarie commented 3 years ago

Apart from the failing tests in legacy python versions (see my comments) it seems ok. Nice suggestion to also provide the cross-steps bag!

j-carson commented 3 years ago

I hit apply on the legacy python suggestions. Let me know if there's anything else I should do.

smarie commented 3 years ago

Apparently a few jobs are still failing. I'll have a look tomorrow

j-carson commented 3 years ago

I think I fixed it.

smarie commented 2 years ago

Thanks ! It seems that it was actually my mistake :( sorry about that.

All set, ready to merge and release