search

smarkets / marge-bot

A merge-bot for GitLab
BSD 3-Clause "New" or "Revised" License
701 stars 136 forks source link

Update API for remove source branch on merge. #191

Closed Viatorus closed 5 years ago

Viatorus commented 5 years ago

To accept an MR and remove the source branch one has to set should_remove_source_branch like mention here: https://docs.gitlab.com/ee/api/merge_requests.html#accept-mr

I also checked older versions (10.3). It was always should. Maybe in v3 it was different.

JaimeLennox commented 5 years ago

Ah, my bad. I accepted #175 with a quick look at the docs, but it seems that was for creating an MR, not accepting, so I believe you are right. It's quite annoying that this parameter changes name between these two calls.