search

smarkets / marge-bot

A merge-bot for GitLab
BSD 3-Clause "New" or "Revised" License
701 stars 136 forks source link

Fix unassign when author is marge #211

Closed JaimeLennox closed 5 years ago

JaimeLennox commented 5 years ago

According to the docs:

"Set to 0 or provide an empty value to unassign all assignees."[1]

So setting to None seems like it would work, although in practice it doesn't.

I've manually tested with 0 and it works fine.

[1] https://docs.gitlab.com/ee/api/merge_requests.html#update-mr

Fixes: #189

micheelengronne commented 5 years ago

The problem is that it remove the PR from any assignee. Making it lost in the void :)

micheelengronne commented 5 years ago

I am working on a solution to avoid the flood that keeps assignees https://github.com/smarkets/marge-bot/pull/210 I just have to figure out how to add an endpoint in the mock.

aschmolck commented 5 years ago

@micheelengronne Removing the PR from any assignee (and maybe leaving a comment about user error) is the correct behaviour. Marge-bot is not meant to be the author of PRs, and although this should fail gracefully (maybe with an explanatory note), I'm not interested in code support beyond this, since it's nothing that can ever work particularly well in the first place.

Having said that, if there is something that would be desirable for other reasons and helps this unsupported use case I might still consider merging it.