Allow configuring the git ssh command

smarkets / marge-bot

A merge-bot for GitLab

BSD 3-Clause "New" or "Revised" License

701 stars 136 forks source link

Allow configuring the git ssh command #235

Closed aclemons closed 2 years ago

aclemons commented 5 years ago

I need to configure the git ssh command to be git-ssh-proxy in an enviroment. Could we make GIT_SSH_COMMAND configurable for this?

aclemons commented 5 years ago

I've opened a PR with a possible solution.

RobertKirk commented 4 years ago

Why do you need the git ssh command to be a different command?

aclemons commented 4 years ago

In our environment, we need need to use a proxy. Something like:

/usr/bin/ssh -o ProxyCommand='nc -X connect -x gateway:8080 %h %p' -o StrictHostKeyChecking=no

RobertKirk commented 4 years ago

If you want to add the option (which I'm not against, as we don't allow configuring the ssh command currently), could you add it to all the other places that configuration options can be set? off the top of my head

documentation (just the README.md I think)
marge/app.py for passing in configuration on the command line
- You'll then need to pass the configuration through to the RepoManager and then to Repo so that the option is overwridden in the Repo.git command.

It'd be good to write a test as well.

matthiasbalke commented 3 years ago

Maybe cloning using HTTPS (#283) is a valid alternative for you @aclemons

aclemons commented 2 years ago

Closing this, since I no longer need it and it seems no one else does either. Feel free to re-open if needed.