smarkets / marge-bot

A merge-bot for GitLab
BSD 3-Clause "New" or "Revised" License
701 stars 136 forks source link

reviewers stripped on gitlab CE #242

Open anholt opened 4 years ago

anholt commented 4 years ago

freedesktop.org uses gitlab CE, so we can't use the approvals feature. However, the release has --add-reviewers by default which seems to strip off Reviewed-by tags that were already in the commit. Any chance you could detect that approvals aren't supported on the gitlab instance and avoid stripping that tag out of our commits?

anholt commented 4 years ago

I think I've got this worked around with dropping --add-reviewers from the deploy.yml.

alatiera commented 4 years ago

Might be unrelated but I recall that specific feature was requiring gitlab admin privileges to function.