smarkets / marge-bot

A merge-bot for GitLab

BSD 3-Clause "New" or "Revised" License

693 stars 136 forks source link

Some code quality ideas #331

Open arvidj opened 2 years ago

arvidj commented 2 years ago

I'm wondering what your general feeling would be about:

Using poetry for dependency management for those not using nix.
Using a code formatter like black.
Using typehints and typechecker like mypy. I've experimented using pyannotate to annotate tests/gitlab_api_mock.py (it required a fair deal of manual annotation though) and found the resulting file far easier to understand.

JohnVillalovos commented 2 years ago

291 Has some poetry work going on there.

arvidj commented 2 years ago

FYI, black is now stable , and is used by e.g. Drupal.

nejch commented 2 years ago

I guess all of this is also related to https://github.com/smarkets/marge-bot/issues/295, as there's more quality of life stuff for developers discussed there, but there's a bit of a backlog already.