search

smarkets / react-native-paypal

React Native library that implements PayPal Checkout flow using purely native code
MIT License
118 stars 54 forks source link

[ANDROID] Promise is not resolving on second time paying. #67

Closed dkfl1995 closed 3 years ago

dkfl1995 commented 3 years ago

Hi guys. Few days ago started with upgrading BT SDK from 2.17 to latest 3.14.2 as faced Google Play team warning like related to this issue. Found really disgusting issue right there then after upgrading. If you use like new 3.14.2 BT SDK version promise on requestOneTimePayment native method still remains the same each time you trigger this method. This lead to promise to be useless as it won't run resolve or reject on second request and then. HashCode of promise still remains the same. As on BT SDK v2.17 promise has different HashCode each time you trigger requestOneTimePayment method.

krupalikevadiya commented 3 years ago

Yes found same issue in android only.Have you found any solution for it?

dkfl1995 commented 3 years ago

@krupalikevadiya actually, having a talk with PayPal development team so they researching this issue. Once I will get any response, will write right there

valerio-fornace commented 3 years ago

Are there any kind of news about this issue?

nzankich commented 3 years ago

@valerio-fornace There's an open MR that needs a tweak but it should be ready to go after that. If I don't get a response for a few days I'll finish up the fix and do a release

valerio-fornace commented 3 years ago

@nzankich thanks this is a good news!

nzankich commented 3 years ago

fixed on 4.0.1

be sure to follow the upgrade instructions for 4.0.0 https://github.com/smarkets/react-native-paypal/releases/tag/4.0.0

Talha-Jawed commented 2 years ago

@nzankich still getting same issue in android.

"react-native": "0.64.2", "react-native-paypal": "4.1.0",