search

smarongiu / Xamarin.Plugin.Firebase.RemoteConfig

Xamarin Forms bindings for Firebase RemoteConfig
MIT License
7 stars 5 forks source link

[Enhancerment] Add GetObject method #5

Open KennyDizi opened 4 years ago

KennyDizi commented 4 years ago

get json from Firebase configuration then parse to your class with power of .Net Json

KennyDizi commented 4 years ago

@smarongiu pls review, merge and update nuget package dependencies

KennyDizi commented 4 years ago

update nuget packages

vhugogarcia commented 4 years ago

Great PR @xamarindevelopervietnam Thanks for updating those packages.

What do you think @smarongiu ? could you give us a hand by review it and approve it, so it can be merged and we can use the latest versions.

Thanks in advance for this great plugin.

Px7-941 commented 4 years ago

@xamarindevelopervietnam Why do you use Newtonsoft.Json and not System.Text.Json? There should be as few external dependencies as possible. For example: The nuget "Plugin.CurrentActivity" could be easily removed. The JsonSerializerSettings should be configurable from the outside.

I hope these inputs help to improve the PR.