Ensure there's only a single CSV header written into the data file - Githubissues

smarr / ReBench

Execute and document benchmarks reproducibly.

MIT License

85 stars 24 forks source link

Ensure there's only a single CSV header written into the data file #227

Closed smarr closed 1 year ago

smarr commented 1 year ago

This fixes #223.

We assume that we only need to write a CSV header into an empty file. Thus, we can check whether the file already contains data. If that's the case, we only write the metadata, but not the CSV header.

This PR also includes two other minor bits:

it fixes the rebench.conf file to work without error (test-vm1.py was changed in 2018 to take 5 arguments)
in some strange conditions, the return_code from running a benchmark command can be None, which breaks output, so, None needs to be handled separately

@naomiGrew please have a look, and review the PR

coveralls commented 1 year ago

coverage: 83.079% (+0.05%) from 83.034% when pulling feebeb611f4409ebcba065a60e3393281a69159b on single-csv-header-per-file into cd302d5155c73575c2b158034afcde07d2403c6d on master.