Document the `env` directive and discuss environment handling in more detail.

smarr / ReBench

Execute and document benchmarks reproducibly.

MIT License

85 stars 24 forks source link

Document the `env` directive and discuss environment handling in more detail. #248

Closed vext01 closed 3 months ago

vext01 commented 3 months ago

I think this addresses the points raised in https://github.com/smarr/ReBench/issues/247. Let me know what you think.

Fixes #247

vext01 commented 3 months ago

[As an aside, if you really want to start with the empty environment, you could use Popen(shell=False, ...), then the system shell could have no influence on the environment I think?]

smarr commented 3 months ago

Sorry for the delay.

Looks great, though I just pushed two changes. I added similar notes on env: for benchmark and executor and removed the Popen implementation detail: https://github.com/smarr/ReBench/pull/248/commits/18cabcc505e678dbd7022fdf1d43f761dc56aadc

Is that ok?

Thanks!

vext01 commented 3 months ago

Thanks Stefan!