search

smarr / ReBench

Execute and document benchmarks reproducibly.
MIT License
85 stars 24 forks source link

Evaluate using `Popen(shell=False, ...)` #250

Open smarr opened 3 months ago

smarr commented 3 months ago

Should we avoid using the shell for running commands?

Think this is a major change at the core of ReBench. So, we'd probably need to carefully test this. See https://github.com/smarr/ReBench/pull/248#issuecomment-2269272256

smarr commented 3 months ago

At the moment, we request explicitly the use of a shell here: https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L532

However, we run build commands without shell here: https://github.com/smarr/ReBench/blob/master/rebench/executor.py#L397