smarr / are-we-fast-yet

Are We Fast Yet? Comparing Language Implementations with Objects, Closures, and Arrays
Other
334 stars 36 forks source link

Upgrade Squeak32 from 5.1 to 5.2; add Squeak64-5.2 #46

Closed fniephaus closed 5 years ago

fniephaus commented 5 years ago

The default VM for Squeak 5.2 uses a heartbeat thread (AWFY used an itimer VM before).

fniephaus commented 5 years ago

Looks like this breaks RSqueak which is still 32bit. @krono @timfel does it make sense to update RSqueak to 64bit or shall we keep the 32bit version for now?

krono commented 5 years ago

Strange. RSqueak can compile as 64 for some time now and reads 32 and 64 images just fine, as far as I remember…

timfel commented 5 years ago

No, we read only 32bit images. We just convert them to pseudo 64bits on the fly


From: Tobias Pape notifications@github.com Sent: Friday, May 3, 2019 7:27:51 PM To: smarr/are-we-fast-yet Cc: Tim Felgentreff; Mention Subject: Re: [smarr/are-we-fast-yet] Upgrade from Squeak32-5.1 to Squeak64-5.2 (#46)

Strange. RSqueak can compile as 64 for some time now and reads 32 and 64 images just fine, as far as I remember…

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/smarr/are-we-fast-yet/pull/46#issuecomment-489175653, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAALJG4PQRKJ6PLXV6DDMODPTRYZPANCNFSM4HKUTWZQ.

fniephaus commented 5 years ago

Ok, I've renamed Squeak to Squeak32 and added Squeak64. 64bit performance should be better due to larger SmallIntegers and SmallFloat64s.

fniephaus commented 5 years ago

I think I'm done cleaning everything up...RSqueak failed when executing the CD benchmark (which is why it's probably listed as allowed failure), the Ruby build failed due to a code style problem, and Lua failed due to some unrelated error.

fniephaus commented 5 years ago

I'd say this can be merged :)

smarr commented 5 years ago

Thanks! Rebased and merged, and CI is green 😄

fniephaus commented 5 years ago

Great, thanks!