smart--petea / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Ninja generator: spaces & other special characters not properly escaped #386

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
There are several cases where Gyp's Ninja generator blindly writes out strings 
into the generated .ninja build scripts without first escaping them of spaces 
and other characters. This can cause ninja to abort at build time.

The sample project attached demonstrates some of the cases I found: 

- a target's 'target_name' cannot contain a space
- a target cannot depend on another target that lives in a directory containing 
a space or a dollar sign

Tested with r1797 on OS X 10.9.

Original issue reported on code.google.com by nshutchi...@gmail.com on 25 Nov 2013 at 11:03

Attachments: