smart-data-lake / sdl-visualization

Visualization for SDLB config

GNU General Public License v3.0

4 stars 1 forks source link

Implement mongo db connector #51

Closed Entouanes closed 1 year ago

Entouanes commented 1 year ago

What's new?

A new class typescript class ("src/api/fetchAPI_mongoDB.ts") serves as a connector to allow the UI to browse statefiles served by a mongoDB backend and delivered by an API (implemented using fastAPI)
From the user perspective nothing changes

What should be improved?

The backend suffers inconsistencies (workflows page will for example show the different workflows in a random order at every refresh)
~~Add the possibility to configure the mongoDB connection in manifest.json~~

Entouanes commented 1 year ago

Implementation of review suggestions:

In the last commit a functionality was added (as suggested by @zzeekk ) that allows to set a "backendConfig" field. It has format ´;´. If for example it is set to ´local;´ it will look for the statefiles locally (in this setting there also exists the possibility to specify the path to an index for local files as statfilesIndex. By default it will be searched in "/state")

zzeekk commented 1 year ago

@pgruetter : would you like to review this as well, or can @Entouanes merge?

pgruetter commented 1 year ago

Thanks, one review is enough. Feel free to merge.