search

smart-data-models / dataModel.Environment

Environment Data Model
Other
12 stars 15 forks source link

Included Description #9

Closed MohamedSadiq102 closed 3 years ago

albertoabellagarcia commented 3 years ago

General observations 1.- What is called 'normative references' are in fact the actual model, so it should have a preference over text, number, etc for being in the Model:'' clause 2.- All the description fo spec.md should be included in the description (specifically the allowed values) 3.- when there is a $ref is not possible to include the description. In fact, what I am doing is copying the definition from the $ref, replacing it and including the description otherwise, it is not json schema compliant. 4.- Regarding entity type. The description has to be 'It has to be 'type of the entity'. 5.- The units have to be included as : Units:'unit'. in the description.

Please review these five data models as long as there are several issues from these 5 points. Possibly you have doubts, please let me know.

albertoabellagarcia commented 3 years ago

Many definitions of data models are missing to be included. specially in waterObserved and in waterQualityObserved, it is required to pass these definitions to the schema.json