smart-data-models / dataModel.WaterDistributionManagementEPANET

Data models for describing a water distribution infrastructure, also compatible with EPANET simulation tool
Other
15 stars 18 forks source link

fix: sourceCategory is missing a value property #28

Closed auphofBSF closed 2 years ago

auphofBSF commented 2 years ago

When trying to validate an object derived from Tank/schema.json against Tank/examples/example.json the sourceCategory.value in the example is being rejected. ( my model based on Tank/schema.json is configured to reject extra fields. sourceCategory.value is not defined in schema by adding as per this PR, my model tests pass.

I Have not assessed other examples in Tank or other schema/model definitions in Tank