smart-edge-open / EMCO

Apache License 2.0
13 stars 9 forks source link

fix clusterrolebinding manifest to allow namespace different from "default" #5

Open BaudouinH opened 3 years ago

BaudouinH commented 3 years ago

Hello,

While installing emco-monitor with Helm, I ran into the following issue: If you try to install emco-monitor into a namespace different from "default", the clusterrolebinding will still be created in the namespace "default", because its value is hardcoded, and emco-monitor will be unable to query Kubernetes API.

With this change, the clusterrolebinding will be deployed in the namespace of the Helm release, like the other objects of this Helm chart.

It is a very small change, and this workflow of PR might not be the most adapted to the project ?