search

smart-edge-open / edgeapps

Applications that can be onboarded to an Intel® Smart Edge Open edge node.
Apache License 2.0
51 stars 73 forks source link

Radisys Engage Media Server #37

Closed nirishah closed 3 years ago

nirishah commented 3 years ago

HelmCharts and Readme file.

amr-mokhtar commented 3 years ago

Hi @nirishah! Please upload the source files (instead of binaries) so that it can be reviewed. For the readme document it has be named as README.md and written in Markdown format, and the Helm chart is a folder that named as helm-chart.. A good example is this app.

nirishah commented 3 years ago

Hi @nirishah! Please upload the source files (instead of binaries) so that it can be reviewed. For the readme document it has be named as README.md and written in Markdown format, and the Helm chart is a folder that named as helm-chart.. A good example is this app.

I have uploaded the README.md file. please check.

amr-mokhtar commented 3 years ago

Hi @nirishah! Thanks for the updates. The changes look good. Let's try to fix the errors flagged by Travis to allow it passing:

Checking Licence Headers
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/readme.md has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/values.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/.helmignore has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/NOTES.txt has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/vmrf_persistentVolume.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/Chart.yaml has incorrect licence header

BTW, the correct copyright header syntax is here.

nirishah commented 3 years ago

Hi @nirishah! Thanks for the updates. The changes look good. Let's try to fix the errors flagged by Travis to allow it passing:

Checking Licence Headers
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/readme.md has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/values.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/.helmignore has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/NOTES.txt has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/vmrf_persistentVolume.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/Chart.yaml has incorrect licence header

BTW, the correct copyright header syntax is here.

Hello @amr-mokhtar, I guess, we need to change the copy right header to suggested format and that is the only license header, right?

amr-mokhtar commented 3 years ago

Hi @nirishah! Thanks for the updates. The changes look good. Let's try to fix the errors flagged by Travis to allow it passing:

Checking Licence Headers
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/readme.md has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/values.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/.helmignore has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/NOTES.txt has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/templates/vmrf_persistentVolume.yaml has incorrect licence header
Error: File /home/travis/build/open-ness/edgeapps/applications/radisys/Helm-Chart/Chart.yaml has incorrect licence header

BTW, the correct copyright header syntax is here.

Hello @amr-mokhtar, I guess, we need to change the copy right header to suggested format and that is the only license header, right?

Yes, we should use SPDX style copyright header with the license being Apache-2.0