smart-facility / cognicity-rem-web

Cognicity REM web site
Other
0 stars 0 forks source link

User management #12

Closed matthewberryman closed 8 years ago

matthewberryman commented 8 years ago
matthewberryman commented 8 years ago

Even before we wrap this up, it would be great to at least have the password field set as a password field (so characters entered appear as asterisks) prior to the demo. @benatwork99

matthewberryman commented 8 years ago

The password field is behaving properly this morning for me, across IE11 and Chrome (Mac) and Safari. So just leave it as is.

benatwork99 commented 8 years ago

That was me, I committed that yesterday but forgot that issue #12 was in cognicity-rem-web (commit was to cognicity-rem-server!)

On 5 February 2016 at 08:06, Matthew Berryman notifications@github.com wrote:

The password field is behaving properly this morning for me, across IE11 and Chrome (Mac) and Safari. So just leave it as is.

— Reply to this email directly or view it on GitHub https://github.com/smart-facility/cognicity-rem-web/issues/12#issuecomment-180048716 .

matthewberryman commented 8 years ago

Ah, that's why I couldn't find it in commit history for cognicity-rem-web, it was handled by cogncity-rem-server. My bad. I must have tested yesterday before I deployed that set of commits. :+1:

benatwork99 commented 8 years ago

All good, I referenced issue #12 but also forgot the issue was in another project so the commit didn't link to the issue properly!

On 5 February 2016 at 09:23, Matthew Berryman notifications@github.com wrote:

Ah, that's why I couldn't find it in commit history for cognicity-rem-web, it was handled by cogncity-rem-server. My bad. I must have tested yesterday before I deployed that set of commits. [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/smart-facility/cognicity-rem-web/issues/12#issuecomment-180077872 .

benatwork99 commented 8 years ago

I'm thinking about a simple schema for this - one user table with columns hardcoded to the roles. E.g., the user table may have these columns: id, username, password, editor, admin

I thought we could have admin as a role as well, meaning a user who has access to the user management section.

Those are the only items worth calling out - let me know if you don't like the sound of them. Apart from that, I'll proceed as discussed - setup the schema, move the users to the database, add a user UI control, add a logout function, adding (very basic) user management pages, and fixing the implementation of read-only vs edit mode in the UI code.

matthewberryman commented 8 years ago

Sounds good—I had envisaged two roles editor and admin (and users can be assigned one or the other or both, hence two columns).

benatwork99 commented 8 years ago

I think this has now been all handled or spawned separate tasks, see:

https://github.com/smart-facility/cognicity-rem-server/issues/7 https://github.com/smart-facility/cognicity-rem-server/issues/1 https://github.com/smart-facility/cognicity-rem-server/issues/23 https://github.com/smart-facility/cognicity-rem-server/issues/24

Closing this issue