search

smart-facility / cognicity-reports-powertrack

cognicity-reports: NodeJS app - Twitter & GNIP PowerTrack support for the CogniCity framework
5 stars 4 forks source link

Don't reply to retweets #26

Closed matthewberryman closed 8 years ago

matthewberryman commented 8 years ago

Unless quoted

matthewberryman commented 8 years ago

The problem is that with the proposed changes, tweets that start with an '@' but that aren't replies will be seen to all followers of the account that sent the tweet. In the bot at present, it also "replies" to people who've retweeted a tweet, but merely tags them without setting the reply metadata up as it can't in that scenario. In that case, once the changes are made by Twitter, followers of the account will see a lot of "spam".

Also, people who are retweeting a tweet are most likely not directly reporting flooding affecting them anyway.

benatwork99 commented 8 years ago

I committed to a branch 'retweet' what should be a fix for this, but did not have time to test this at all (which is why I didn't commit to the refactor branch).

Note that the 'retweet' branch was forked from the 'refactor' branch and CI tests are currently failing because the 'master' branch of cognicity-reports doesn't have the base class refactoring that's expected by the code in this branch. I.e., CI will pass once 'refactor' is merged into master on cognicity-reports.